Make IPC framing more efficient#20793
Merged
ilevkivskyi merged 2 commits intopython:masterfrom Feb 12, 2026
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
hauntsaninja
approved these changes
Feb 12, 2026
| bdata = self.buffer[HEADER_SIZE : HEADER_SIZE + self.message_size] | ||
| self.buffer = self.buffer[HEADER_SIZE + self.message_size :] | ||
| self.message_size = None | ||
| return bytes(bdata) |
Collaborator
There was a problem hiding this comment.
Something like bytes(memoryview(self.buffer)[slice]) might save this copy right? (In 3.15 we can use bytearray.take_bytes)
Member
Author
There was a problem hiding this comment.
Interesting. Yeah, let's do this. Btw it would be great if mypyc could support this as well. I don't think we have any primitives for memoryview.
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not important now, but it will be important when we will start sending serialized ASTs over IPC, using stdlib base64 can easily add 0.5-1ms per file round-trip overhead, which is a lot.
Initially I waned to use
librt.base64, but ultimately simply switched to framing with a fixed size header. I am still usinglibrt.base64in few places where performance doesn't really matter, because why not.Btw I noticed we have very few mypyc primitives for
bytearray, probably we should add more, added comment in mypyc/mypyc#644