perf(trie): use rayon spawn_broadcast for proof workers #22141
+27
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace the
forloop +pool.spawn()pattern withpool.spawn_broadcast()for spawning proof workers.Changes
spawn_broadcaston storage and account proof worker pools inproof_task.rs, getting the worker ID fromBroadcastContext::index()Syncbound toFactorygeneric onProofWorkerHandle::new(required byspawn_broadcast)Syncbound to callers inmod.rsandmultiproof.rsMotivation
spawn_broadcastguarantees exactly one task per pool thread and provides a stable per-thread index via the broadcast context, eliminating the manual loop and per-iteration clones.Prompted by: DaniPopes