-
Notifications
You must be signed in to change notification settings - Fork 66
Switch to pnpm and force its usafe for UI - Remove npm calls from build.rs
#1173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to pnpm and force its usafe for UI - Remove npm calls from build.rs
#1173
Conversation
This Fixes a few things in the build. - First it forces a specific version for npm + node - the LTS version - Second, it allows cargo to leverage docker in the event your local NPM fails (this may need to be configured better) - Finally, this provides a better caching mechanism for cargo so we're not constantly farming out to `npm`. This is pretty critical for the docker fallback.
|
@jerbly Could really use your help trying this out. If I've done this right, then you should have nothing to change because you're on LTS of node. Additionally, any machine that's on a different version will fallback to using PTAL and let me know what you think! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1173 +/- ##
=====================================
Coverage 79.9% 80.0%
=====================================
Files 109 109
Lines 8586 8586
=====================================
+ Hits 6868 6869 +1
+ Misses 1718 1717 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@jsuereth - To have |
…sion-and-docker-backup
…on-and-docker-backup
…e UI but request you do it locally.
pnpm and force its usafe for UI - Remove npm calls from build.rs
jerbly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This Fixes a few things in the build.
pnpmas a package manager.build.rsif node is not build, and warnings if it is not up to date. It should not longer try to call node executables from inside cargo.