src: remove unnecessary c_str() conversions in diagnostic messages#61786
Open
addaleax wants to merge 1 commit intonodejs:mainfrom
Open
src: remove unnecessary c_str() conversions in diagnostic messages#61786addaleax wants to merge 1 commit intonodejs:mainfrom
c_str() conversions in diagnostic messages#61786addaleax wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
c_str() conversions in diagnsotic messagesc_str() conversions in diagnostic messages
14e6ee5 to
bc7ab07
Compare
bc7ab07 to
0428717
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61786 +/- ##
==========================================
- Coverage 89.76% 89.74% -0.02%
==========================================
Files 675 675
Lines 204674 204660 -14
Branches 39330 39329 -1
==========================================
- Hits 183716 183682 -34
- Misses 13235 13241 +6
- Partials 7723 7737 +14
🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Feb 12, 2026
geeksilva97
approved these changes
Feb 12, 2026
gireeshpunathil
approved these changes
Feb 12, 2026
This comment was marked as outdated.
This comment was marked as outdated.
legendecas
approved these changes
Feb 12, 2026
Collaborator
aymen94
approved these changes
Feb 12, 2026
Qard
approved these changes
Feb 12, 2026
lpinca
approved these changes
Feb 12, 2026
RafaelGSS
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.