[Application QuickStart] [Backend] DAB Connection string transformation for Docker containers #21180

manujoseph85 · 2026-02-12T19:18:45Z

Description

The default connection string from the Object Explorer will point to localhost (or other forms) for local sqlserver deployment. For DAB deployed in Docker we need to transform this for DAB (to host.docker.internal) to be able to redirect to host correctly.

Added a new sqlServerContainerName property to the Dab.DabConnectionInfo interface
transformConnectionInfoForDocker in dabService now checks for localhost and its variants in the provided connection string and transforms it to
- host.docker.internal\${sqlServerContainerName} for sqlserver in local containers
- host.docker.internal for local sqlserver instance

Testing and validation:

Added extensive unit tests for connection string transformation logic, covering edge cases, localhost variants, containerized SQL Server, and integration with config generation.

Code Changes Checklist

New or updated unit tests added
All existing tests pass (npm run test)
Code follows contributing guidelines
Telemetry/logging updated if relevant
No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

Copilot

Pull request overview

This PR implements connection string transformation for DAB (Data API Builder) deployments in Docker containers. When DAB runs in a Docker container and needs to connect to SQL Server, localhost references in connection strings must be transformed to enable proper communication across container boundaries.

Changes:

Added sqlServerContainerName property to DabConnectionInfo interface to support containerized SQL Server scenarios
Implemented transformConnectionInfoForDocker method that replaces localhost variants (localhost, 127.0.0.1, (local), .) with host.docker.internal for Docker networking
Updated runDeploymentStep signature to accept DabConnectionInfo instead of just connection string
Added comprehensive unit tests covering transformation logic edge cases and integration scenarios

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
extensions/mssql/src/sharedInterfaces/dab.ts	Added `sqlServerContainerName` optional property to `DabConnectionInfo` interface and updated `runDeploymentStep` parameter from `connectionString` to `connectionInfo`
extensions/mssql/src/services/dabService.ts	Implemented `transformConnectionInfoForDocker` with helper methods to parse and transform localhost addresses; integrated transformation into `generateConfig` method
extensions/mssql/src/schemaDesigner/schemaDesignerWebviewController.ts	Added `_sqlServerContainerName` field and `resolveSqlServerContainerName` method to extract container name from connection profile; updated DAB service calls to pass `DabConnectionInfo`
extensions/mssql/test/unit/dab/dabService.test.ts	Added extensive test suites covering localhost variants, port/instance preservation, containerized SQL Server scenarios, and edge cases; updated existing tests to use `DabConnectionInfo`
extensions/mssql/test/unit/schemaDesignerWebviewController.test.ts	Added tests for connection string transformation in config generation and container name resolution from different sources

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

extensions/mssql/test/unit/schemaDesignerWebviewController.test.ts

extensions/mssql/src/services/dabService.ts

extensions/mssql/test/unit/dab/dabService.test.ts

extensions/mssql/src/services/dabService.ts

github-actions · 2026-02-12T22:35:15Z

PR Changes

Category	Target Branch	PR Branch	Difference
vscode-mssql VSIX	5976 KB	5972 KB	⚪ -4 KB ( 0% )
sql-database-projects VSIX	7758 KB	7917 KB	🔴 159 KB ( 2% )
data-workspace VSIX	537 KB	536 KB	⚪ -1 KB ( 0% )

codecov-commenter · 2026-02-12T22:35:31Z

Codecov Report

❌ Patch coverage is 97.67442% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 69.21%. Comparing base (a6162a4) to head (66718e3).
⚠️ Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
.../schemaDesigner/schemaDesignerWebviewController.ts	87.50%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #21180      +/-   ##
==========================================
+ Coverage   69.13%   69.21%   +0.07%     
==========================================
  Files         255      255              
  Lines       25160    25200      +40     
  Branches     3284     3293       +9     
==========================================
+ Hits        17395    17441      +46     
+ Misses       7629     7623       -6     
  Partials      136      136

Files with missing lines	Coverage Δ
extensions/mssql/src/deployment/dockerUtils.ts	`93.00% <ø> (ø)`
extensions/mssql/src/services/dabService.ts	`93.70% <100.00%> (+2.12%)`	⬆️
extensions/mssql/src/sharedInterfaces/dab.ts	`98.27% <ø> (ø)`
.../schemaDesigner/schemaDesignerWebviewController.ts	`80.09% <87.50%> (+0.80%)`	⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

extensions/mssql/src/services/dabService.ts

aasimkhan30 · 2026-02-13T00:23:17Z

extensions/mssql/src/services/dabService.ts

+        const serverValue = serverMatch[1].trim();
+
+        // Parse the server address to check if it's localhost
+        const host = this.parseHostFromServerValue(serverValue);


Isn't this information already in connectionInfo?

connectionString was already available in DabService. I will file an improvement item for using connectionManager to do the rewrite.

aasimkhan30 · 2026-02-13T00:27:49Z

extensions/mssql/src/services/dabService.ts

+        let newServerValue: string;
+        if (sqlServerContainerName) {
+            // Extract port if present (comma-separated), discard any instance name
+            const commaIndex = serverValue.indexOf(",");


Please use the connection info object from to get these details directly instead of parsing it from connection string.

I think we should use the original connection info, clone it, mutate it and then create a connection string out of it. It will be less brittle than regexes.

vscode-mssql/extensions/mssql/src/connectionconfig/connectionDialogWebviewController.ts

Lines 606 to 627 in a29a77f

const connectionDetails =

this._mainController.connectionManager.createConnectionDetails(

cleanedConnection,

);

let tempUserId = false;

if (

connectionDetails.options.authenticationType ===

AuthenticationType.AzureMFA &&

connectionDetails.options.user === undefined

) {

// STS call for getting connection string expects a user when AzureMFA is used; if user is not set, set it to empty string

connectionDetails.options.user = "";

tempUserId = true;

}

connectionString =

await this._mainController.connectionManager.getConnectionString(

connectionDetails,

true /* includePassword */,

);

Yes, I think thats probably the best way to do it too.

Although, we might have to do some more plumbing in SchemaDesignerWebviewController to do that whereas connectionString was already available. We are only replacing in a narrow case - Server part when its localhost. So, I think the regex matches here are less error prone.

So, I will merge this for now and file an improvement item for using connectionManager to do the rewrite.

aasimkhan30

Looks good with minor comments.

Connection string tansformation for Docker containers

7471830

manujoseph85 added the Area - Application QuickStart label Feb 12, 2026

manujoseph85 marked this pull request as ready for review February 12, 2026 21:20

manujoseph85 requested review from aasimkhan30, caohai and kburtram as code owners February 12, 2026 21:20

Copilot AI review requested due to automatic review settings February 12, 2026 21:20

manujoseph85 requested review from Benjin, allancascante, laurenastrid1, lewis-sanchez and ssreerama as code owners February 12, 2026 21:20

Copilot started reviewing on behalf of manujoseph85 February 12, 2026 21:21 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

manujoseph85 added 2 commits February 12, 2026 14:22

PR review fixes

97293c5

Merge branch 'main' into dev/majoseph/dabutils-refactor

bc4c372

manujoseph85 requested a review from Copilot February 12, 2026 23:13

Copilot started reviewing on behalf of manujoseph85 February 12, 2026 23:13 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

extensions/mssql/src/services/dabService.ts Show resolved Hide resolved

extensions/mssql/src/services/dabService.ts Show resolved Hide resolved

caohai previously approved these changes Feb 12, 2026

View reviewed changes

Fix for Linux docker to add host mapping explicitly

66718e3

manujoseph85 dismissed caohai’s stale review via 66718e3 February 13, 2026 00:01

aasimkhan30 reviewed Feb 13, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Application QuickStart] [Backend] DAB Connection string transformation for Docker containers #21180

[Application QuickStart] [Backend] DAB Connection string transformation for Docker containers #21180

manujoseph85 commented Feb 12, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 12, 2026 •

edited

Loading

Uh oh!

codecov-commenter commented Feb 12, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

aasimkhan30 Feb 13, 2026

Uh oh!

manujoseph85 Feb 13, 2026

Uh oh!

aasimkhan30 Feb 13, 2026 •

edited

Loading

Uh oh!

manujoseph85 Feb 13, 2026

Uh oh!

aasimkhan30 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	const connectionDetails =
	this._mainController.connectionManager.createConnectionDetails(
	cleanedConnection,
	);

	let tempUserId = false;

	if (
	connectionDetails.options.authenticationType ===
	AuthenticationType.AzureMFA &&
	connectionDetails.options.user === undefined
	) {
	// STS call for getting connection string expects a user when AzureMFA is used; if user is not set, set it to empty string
	connectionDetails.options.user = "";
	tempUserId = true;
	}

	connectionString =
	await this._mainController.connectionManager.getConnectionString(
	connectionDetails,
	true /* includePassword */,
	);

[Application QuickStart] [Backend] DAB Connection string transformation for Docker containers #21180

Are you sure you want to change the base?

[Application QuickStart] [Backend] DAB Connection string transformation for Docker containers #21180

Conversation

manujoseph85 commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Code Changes Checklist

Reviewers: Please read our reviewer guidelines

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Changes

Uh oh!

codecov-commenter commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

aasimkhan30 Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

manujoseph85 Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

aasimkhan30 Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

manujoseph85 Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

aasimkhan30 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

manujoseph85 commented Feb 12, 2026 •

edited

Loading

github-actions bot commented Feb 12, 2026 •

edited

Loading

codecov-commenter commented Feb 12, 2026 •

edited

Loading

aasimkhan30 Feb 13, 2026 •

edited

Loading