Skip to content

Conversation

@Benjin
Copy link
Contributor

@Benjin Benjin commented Feb 11, 2026

Description

Now that all of our features are "rich" and many are GAed, I'm retiring this. For future feature gates (private preview) , use useExperimentalFeatures which defaults to off.

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the legacy mssql.enableRichExperiences setting/command/prompt and makes previously “rich” UI features always available, while directing future feature-gating to mssql.enableExperimentalFeatures (default off).

Changes:

  • Removes enableRichExperiences configuration, related command/prompt telemetry, and conditional feature gating.
  • Updates Object Explorer and command contributions so rich features (e.g., deployment node, schema designer) are no longer hidden behind a setting.
  • Refreshes localization/strings and telemetry payload fields (including unit test updates).

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
localization/xliff/vscode-mssql.xlf Removes/updates English source strings referencing enableRichExperiences, adds preview-feature walkthrough strings.
extensions/mssql/test/unit/userSurvey.test.ts Updates expected telemetry payload field to experimentalFeaturesEnabled.
extensions/mssql/src/sharedInterfaces/telemetry.ts Removes the EnableRichExperiencesPrompt telemetry action.
extensions/mssql/src/objectExplorer/objectExplorerService.ts Always includes the deployment node (removes rich-experience gating).
extensions/mssql/src/objectExplorer/objectExplorerProvider.ts Removes rich-experience constructor parameter threading.
extensions/mssql/src/nps/userSurvey.ts Renames telemetry property from modern/rich to experimentalFeaturesEnabled.
extensions/mssql/src/controllers/mainController.ts Deletes rich-experiences prompt flow and removes rich-experience gating around feature registration/telemetry.
extensions/mssql/src/constants/locConstants.ts Removes localized prompt/button strings for enabling rich experiences.
extensions/mssql/src/constants/constants.ts Removes rich-experience constants and renames the enable command constant to experimental.
extensions/mssql/package.nls.json Removes rich-experiences strings and updates settings/walkthrough strings.
extensions/mssql/package.json Removes enableRichExperiences setting/command contributions and removes config-based menu gating.
extensions/mssql/l10n/bundle.l10n.json Removes generated bundle entries for the retired prompt/button strings.
Comments suppressed due to low confidence (1)

extensions/mssql/package.json:1277

  • mssql.enableExperimentalFeatures is registered and referenced by the new walkthrough text (command:mssql.enableExperimentalFeatures), but there is no corresponding contributes.commands entry in this package.json (the old mssql.enableRichExperiences command contribution was removed). Without contributing the command, it won’t appear in the Command Palette and loses its localized title/category. Consider adding a contributes.commands entry for mssql.enableExperimentalFeatures (with a localized title) or removing the command-link usage if it’s meant to be settings-only.
            {
                "command": "mssql.copilot.explainQuery",
                "title": "%mssql.copilot.explainQuery%",
                "category": "MS SQL"
            },

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +232 to +234
"mssql.walkthroughs.getStarted.enablePreviewFeatures.title": "Enable Preview Features",
"mssql.walkthroughs.getStarted.enablePreviewFeatures.description": "Enable preview features in the MSSQL extension to try out the latest capabilities.\n[Enable Preview Experiences](command:mssql.enableExperimentalFeatures)",
"mssql.walkthroughs.getStarted.enablePreviewFeatures.altText": "Enable preview features in MSSQL",
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mssql.walkthroughs.getStarted.enablePreviewFeatures.* strings were added/renamed here, but extensions/mssql/package.json’s contributes.walkthroughs section doesn’t reference these keys (no step uses them). Either wire these strings into the walkthrough contributions or remove them to avoid unused localization entries.

Suggested change
"mssql.walkthroughs.getStarted.enablePreviewFeatures.title": "Enable Preview Features",
"mssql.walkthroughs.getStarted.enablePreviewFeatures.description": "Enable preview features in the MSSQL extension to try out the latest capabilities.\n[Enable Preview Experiences](command:mssql.enableExperimentalFeatures)",
"mssql.walkthroughs.getStarted.enablePreviewFeatures.altText": "Enable preview features in MSSQL",

Copilot uses AI. Check for mistakes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Benjin , Do we want this walkthrough loc strings? Also maybe remove walkthrough?

Comment on lines 5867 to 5869
<trans-unit id="mssql.openQueryResultsInTabByDefault.description">
<source xml:lang="en">Automatically display query results in a new tab instead of the query pane. This option takes effect only if `mssql.enableRichExperiences` is enabled.</source>
<source xml:lang="en">Automatically display query results in a new tab instead of the query pane.</source>
</trans-unit>
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the English XLIFF was updated to remove mssql.enableRichExperiences references, but multiple localized XLIFFs (e.g. localization/xliff/vscode-mssql.de.xlf, .es.xlf, .fr.xlf, etc.) still contain the old source strings/command links and setting descriptions referencing mssql.enableRichExperiences. Run yarn localization and commit the resulting updates to localization/xliff/*.xlf so all locales stay in sync with the retired setting/command.

Copilot uses AI. Check for mistakes.
Comment on lines 1401 to 1406
"mssql.enableExperimentalFeatures": {
"type": "boolean",
"default": false,
"description": "%mssql.enableExperimentalFeatures.description%",
"scope": "application"
},
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still repository docs referencing the retired mssql.enableRichExperiences setting (e.g. root README.md, extensions/mssql/README.md, extensions/mssql/FEATURES.md, and changelogs). Since this PR removes the setting from contributes.configuration, those docs should be updated/cleaned up to avoid directing users to a nonexistent setting.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

PR Changes

Category Target Branch PR Branch Difference
vscode-mssql VSIX 5945 KB 5937 KB ⚪ -8 KB ( 0% )
sql-database-projects VSIX 7913 KB 7913 KB ⚪ 0 KB ( 0% )
data-workspace VSIX 536 KB 536 KB ⚪ 0 KB ( 0% )

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 23.07692% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.35%. Comparing base (d00df05) to head (084bc3f).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
extensions/mssql/src/controllers/mainController.ts 20.63% 50 Missing ⚠️

❌ Your patch status has failed because the patch coverage (23.07%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21169      +/-   ##
==========================================
+ Coverage   69.30%   69.35%   +0.04%     
==========================================
  Files         246      246              
  Lines       24309    24275      -34     
  Branches     3187     3179       -8     
==========================================
- Hits        16848    16835      -13     
+ Misses       7329     7308      -21     
  Partials      132      132              
Files with missing lines Coverage Δ
extensions/mssql/src/constants/constants.ts 100.00% <100.00%> (ø)
extensions/mssql/src/constants/locConstants.ts 88.25% <ø> (+0.05%) ⬆️
extensions/mssql/src/nps/userSurvey.ts 73.97% <ø> (ø)
...mssql/src/objectExplorer/objectExplorerProvider.ts 57.14% <ø> (-0.67%) ⬇️
.../mssql/src/objectExplorer/objectExplorerService.ts 71.02% <100.00%> (-0.14%) ⬇️
extensions/mssql/src/sharedInterfaces/telemetry.ts 100.00% <ø> (ø)
extensions/mssql/src/controllers/mainController.ts 18.70% <20.63%> (+0.11%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

{
surveyId: surveyId,
modernFeaturesEnabled: vscode.workspace
experimentalFeaturesEnabled: vscode.workspace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a utility function to avoid repeating?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants