Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 29, 2026

  • Explore the repository and understand the codebase
  • Understand the existing configureOnOpen implementation
  • Implement automatic configure on open when:
    • Makefile is detected in the workspace
    • No previous configure has been done in the codebase lifetime
    • configureOnOpen is not explicitly set to false
  • Add a new TriggeredBy enum value for automatic configure
  • Add unit tests for the new functionality
  • Fix TypeScript syntax error - missing closing brace for test suite block
  • Run code review
  • Run CodeQL security check (passed - no alerts)

Summary of Changes

This PR implements automatic configure on open for Makefile projects:

  1. New behavior when configureOnOpen is not set:

    • First time opening a Makefile project: automatically configure to provide IntelliSense
    • Subsequent opens: prompt the user to choose (existing behavior)
  2. Existing behavior preserved:

    • configureOnOpen: true - always configure on open
    • configureOnOpen: false - never configure on open
  3. Files changed:

    • src/make.ts - Added TriggeredBy.automaticConfigureOnOpen enum value
    • src/extension.ts - Updated configure-on-open logic
    • package.nls.json - Updated setting description
    • src/test/fakeSuite/extension.test.ts - Added unit tests
Original prompt

This section details on the original issue you should resolve

<issue_title>Investigate automatic configure on open</issue_title>
<issue_description>With updates to the Makefile configure experience, investigate automatically configuring on open in future scenarios to add IntelliSense to Makefile projects</issue_description>

<agent_instructions>Please also add tests if it makes sense to.</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

- Add new TriggeredBy.automaticConfigureOnOpen enum value
- Automatically configure on first open when configureOnOpen is not set
- Only prompt on subsequent opens if not explicitly configured
- Update package.nls.json description for configureOnOpen setting
- Add unit tests for the new TriggeredBy value

Co-authored-by: snehara99 <113148726+snehara99@users.noreply.github.com>
Copilot AI changed the title [WIP] Investigate automatic configure on open for Makefile projects Automatic configure on open for first-time Makefile projects Jan 29, 2026
Copilot AI requested a review from snehara99 January 29, 2026 20:31
@snehara99
Copy link
Contributor

@copilot can you fix the following error from the check pipeline?

yarn run v1.22.22
warning makefile-tools@0.7.0: The engine "vscode" appears to be invalid.
$ yarn install && yarn run translations-generate && yarn run bundle-assets && webpack --env BUILD_VSCODE_NLS=true --mode production
[1/5] Validating package.json...
warning makefile-tools@0.7.0: The engine "vscode" appears to be invalid.
[2/5] Resolving packages...
success Already up-to-date.
warning makefile-tools@0.7.0: The engine "vscode" appears to be invalid.
$ gulp translations-generate
[04:46:47] Using gulpfile ~/work/vscode-makefile-tools/vscode-makefile-tools/gulpfile.js
[04:46:47] Starting 'translations-generate'...
[04:46:47] Starting 'generatedSrcLocBundle'...
src/test/fakeSuite/extension.test.ts(974,1): error TS1005: '}' expected.
TypeScript: 1 syntax error
TypeScript: emit succeeded (with errors)
[04:46:51] 'generatedSrcLocBundle' errored after 3.64 s
[04:46:51] Error: TypeScript: Compilation failed
    at Output.mightFinish (/home/runner/work/vscode-makefile-tools/vscode-makefile-tools/node_modules/gulp-typescript/release/output.js:130:43)
    at /home/runner/work/vscode-makefile-tools/vscode-makefile-tools/node_modules/gulp-typescript/release/output.js:43:22
[04:46:51] 'translations-generate' errored after 3.64 s
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

…ace for suite block

Co-authored-by: snehara99 <113148726+snehara99@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 3, 2026

@copilot can you fix the following error from the check pipeline?

...

Fixed in b45c7d2. The test suite block was missing a closing brace }); - the test function was closed but not the suite itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate automatic configure on open

2 participants