Skip to content

chore: Update workflow and tools to use Go 1.26 and 1.25#3995

Open
gmlewis wants to merge 7 commits intogoogle:masterfrom
gmlewis:update-go-1.26
Open

chore: Update workflow and tools to use Go 1.26 and 1.25#3995
gmlewis wants to merge 7 commits intogoogle:masterfrom
gmlewis:update-go-1.26

Conversation

@gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Feb 12, 2026

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Feb 12, 2026
@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.60%. Comparing base (478bf36) to head (1a9585b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3995   +/-   ##
=======================================
  Coverage   93.60%   93.60%           
=======================================
  Files         207      207           
  Lines       17831    17831           
=======================================
  Hits        16690    16690           
  Misses        939      939           
  Partials      202      202           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@Not-Dhananjay-Mishra Not-Dhananjay-Mishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Just one question should we update README.md as well?

go-github/README.md

Lines 15 to 16 in 1732098

We do our best not to break older versions of Go if we don't have to, but we
don't explicitly test older versions and as of Go 1.23 the go directive in

@gmlewis
Copy link
Collaborator Author

gmlewis commented Feb 12, 2026

LGTM. Just one question should we update README.md as well?

go-github/README.md

Lines 15 to 16 in 1732098

We do our best not to break older versions of Go if we don't have to, but we
don't explicitly test older versions and as of Go 1.23 the go directive in

No, that section should stay the same.

Copy link
Contributor

@alexandear alexandear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we ship this change after the go-github release with all the breaking changes? I mean releasing v83 first and then updating the go.mod to Go 1.25.

@gmlewis gmlewis added the DO NOT MERGE Do not merge this PR. label Feb 12, 2026
Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
@gmlewis
Copy link
Collaborator Author

gmlewis commented Feb 12, 2026

Could we ship this change after the go-github release with all the breaking changes? I mean releasing v83 first and then updating the go.mod to Go 1.25.

Great idea, @alexandear - placing this PR on hold until after the release of v83.0.0.

Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a couple of thoughts.

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis
Copy link
Collaborator Author

gmlewis commented Feb 13, 2026

Note to self: #3932 can be addressed once this is merged.

Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Feb 13, 2026
gmlewis and others added 4 commits February 13, 2026 09:41
Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>
Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE Do not merge this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants