chore: Update workflow and tools to use Go 1.26 and 1.25#3995
chore: Update workflow and tools to use Go 1.26 and 1.25#3995gmlewis wants to merge 7 commits intogoogle:masterfrom
Conversation
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3995 +/- ##
=======================================
Coverage 93.60% 93.60%
=======================================
Files 207 207
Lines 17831 17831
=======================================
Hits 16690 16690
Misses 939 939
Partials 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Not-Dhananjay-Mishra
left a comment
There was a problem hiding this comment.
LGTM.
Just one question should we update README.md as well?
Lines 15 to 16 in 1732098
No, that section should stay the same. |
alexandear
left a comment
There was a problem hiding this comment.
Could we ship this change after the go-github release with all the breaking changes? I mean releasing v83 first and then updating the go.mod to Go 1.25.
Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
Great idea, @alexandear - placing this PR on hold until after the release of |
stevehipwell
left a comment
There was a problem hiding this comment.
I've added a couple of thoughts.
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
|
Note to self: #3932 can be addressed once this is merged. |
Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>
Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
cc: @stevehipwell - @alexandear - @zyfy29 - @Not-Dhananjay-Mishra