Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Feb 12, 2026

Complete: Configurable File Type Restrictions with Code Review Fixes ✅

All Review Comments Addressed

Copilot PR Reviewer Feedback (bot comments 2801299441-2801299505):

  1. Normalize allowed extensions: Extensions now converted to lowercase and trimmed
  2. JSON.parse error handling: Added try-catch with clear error messages
  3. Template literal escaping: Fixed $${ to ${ in error messages
  4. Multi-cache extensions: Build union of all extensions when caches differ
  5. Hardcoded repo-memory extensions: Now uses configured extensions from memory config

@pelikhan Request:
6. ✅ Recompile: All 147 workflows recompiled successfully

Changes Summary

JavaScript Validation (validate_memory_files.cjs):

  • Normalizes extensions to lowercase: .map(ext => ext.trim().toLowerCase())
  • Handles mixed-case config like [".MD", ".Json"] correctly

Error Handling (push_repo_memory.cjs):

  • Wrapped JSON.parse(ALLOWED_EXTENSIONS) in try-catch
  • Returns clear error: "Failed to parse ALLOWED_EXTENSIONS... Expected JSON array format."
  • Falls back to defaults on parse error

Template Fix (cache.go):

  • Fixed double-dollar escape: Found $${result...}Found ${result...}
  • Error messages now show actual count instead of literal $3

Multi-Config Support:

  • cache.go: Builds union of extensions when caches have different allowed lists
  • repo_memory_prompt.go: Both single and multi-memory prompts use configured extensions
  • Sorts union for consistent output

Testing

  • ✅ All 175 JavaScript test files passing (3852 tests)
  • ✅ All Go tests passing
  • ✅ 147 workflows recompiled
  • ✅ Format and lint passing

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.


Changeset

  • Type: patch
  • Description: Add configurable allowed extensions for cache-memory and repo-memory along with validation failure reporting

Generated by Changeset Generator


Changeset

  • Type: patch
  • Description: Add configurable allowed extensions for cache-memory and repo-memory along with validation failure reporting

Generated by Changeset Generator

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Update cache memory to support specific file types Restrict cache-memory and repo-memory to allowed file types Feb 12, 2026
Copilot AI requested a review from pelikhan February 12, 2026 16:00
@pelikhan
Copy link
Contributor

The list of allowed file extensions should be configurable through allowed-extensions: [".txt", ".csv", ".json"] @copilot

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 12, 2026

The list of allowed file extensions should be configurable through allowed-extensions: [".txt", ".csv", ".json"] @copilot

Implemented in commit 50c701e. The allowed-extensions field is now configurable for both cache-memory and repo-memory:

tools:
  cache-memory:
    allowed-extensions: [".txt", ".csv", ".json"]
    
  repo-memory:
    allowed-extensions: [".md", ".json", ".toml"]

When not specified, defaults to [".json", ".jsonl", ".txt", ".md", ".csv"]. The configured extensions are:

  • Shown in agent prompts dynamically
  • Validated before upload (cache-memory) and before push (repo-memory)
  • Passed to JavaScript validation via JSON array


// Validate cache-memory file types step
var validateStep strings.Builder
fmt.Fprintf(&validateStep, " - name: Validate cache-memory file types (%s)\n", cache.ID)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot use helper to code generate actions/github-script code

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot refactor this template template in a .md and render it

} else {
fmt.Fprintf(builder, " - name: Validate cache-memory file types (%s)\n", cache.ID)
}
builder.WriteString(" if: always()\n")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot use helper to generate call to actions/github-script

@github-actions
Copy link
Contributor

🔍 PR Triage Results

Category: feature (security) | Risk: medium | Priority: 57/100

Scores Breakdown

  • Impact: 32/50 - Important security feature for memory validation. Affects all workflows using cache-memory/repo-memory (74+ workflows). Good feature but not critical/blocking.
  • Urgency: 10/30 - Medium urgency - security improvement but not fixing active vulnerability. PR age: 2.7 hours. CI pending. No security/P0/P1 labels.
  • Quality: 15/20 - Good quality - Detailed PR description, comprehensive testing with 20 JS tests, CI pending, all unit tests passing mentioned, comprehensive documentation.

📋 Recommended Action: batch_review

Medium risk, medium priority (57/100), good quality. Not auto-mergeable due to pending CI and medium risk level. Should be reviewed but not urgent. Could be batched with other memory/security features if they exist.

Batch Info: Eligible for batch-memory-security-001 (monitor for similar PRs)


Triaged by PR Triage Agent on 2026-02-12T18:26:00Z (Run #21959060330)

AI generated by PR Triage Agent

@pelikhan
Copy link
Contributor

@copilot keep working

…cache prompts

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…ix template escaping, handle multi-config

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 12, 2026

@copilot recompile

Recompiled in commit 5f067ac. All 147 workflows compiled successfully with the code review fixes applied.

@github-actions
Copy link
Contributor

🧪 Smoke Project is now testing project operations...

@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2026

🎬 THE ENDSmoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2026

Changeset Generator completed successfully!

@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2026

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

@github-actions
Copy link
Contributor

📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing...

@github-actions
Copy link
Contributor

Agent Container Tool Check ✅

Tool Status Version
bash 5.2.21
sh available
git 2.52.0
jq 1.7
yq 4.52.2
curl 8.5.0
gh 2.86.0
node 20.20.0
python3 3.12.3
go 1.24.13
java (available)
dotnet 10.0.102

Result: 12/12 tools available ✅ PASS

AI generated by Agent Container Smoke Test

@github-actions
Copy link
Contributor

Smoke Project completed successfully. All project operations validated.

@github-actions
Copy link
Contributor

Smoke Test: Run 21968692105

PRs Tested:

Results:

  • ✅ GitHub MCP
  • ✅ Safe Inputs GH CLI
  • ❌ Serena MCP (not available)
  • ✅ Playwright
  • ✅ File Writing
  • ✅ Bash Tool
  • ✅ Discussion Interaction
  • ✅ Build gh-aw
  • ✅ Workflow Dispatch

Status: PASS (8/9 tests passed)

cc @pelikhan

AI generated by Smoke Copilot

@github-actions github-actions bot removed the smoke label Feb 12, 2026
@github-actions
Copy link
Contributor

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

@github-actions
Copy link
Contributor

PRs: Remove unused generateMaxWithRequiredFieldsConfig function / [WIP] Fix emission of --enable-chroot for awf call
GitHub MCP: ✅
Serena MCP: ✅
Playwright: ✅
File write + cat: ✅
Build gh-aw: ✅
Overall: PASS

AI generated by Smoke Codex

@pelikhan pelikhan merged commit 8aa7bd9 into main Feb 12, 2026
1 check passed
@pelikhan pelikhan deleted the copilot/update-cache-file-type-support branch February 12, 2026 23:49
@github-actions
Copy link
Contributor

Smoke Test Results ✅

PR Titles:

Test Results:

  • ✅ GitHub MCP
  • ✅ Safe Inputs GH CLI
  • ✅ Serena MCP (2 symbols found)
  • ✅ Make Build
  • ✅ Playwright
  • ✅ Tavily Web Search (5 results)
  • ✅ File Writing
  • ✅ Bash Tool
  • ✅ Discussion Interaction
  • ✅ Agentic Workflows MCP

Overall Status: PASS

AI generated by Smoke Claude

@mohamedbouddi7777-dev
Copy link

mohamedbouddi7777-dev commented Feb 13, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants