-
Notifications
You must be signed in to change notification settings - Fork 148
Add configurable file type restrictions to cache-memory and repo-memory with validation failure reporting #15195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
The list of allowed file extensions should be configurable through |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Implemented in commit 50c701e. The tools:
cache-memory:
allowed-extensions: [".txt", ".csv", ".json"]
repo-memory:
allowed-extensions: [".md", ".json", ".toml"]When not specified, defaults to
|
…assing Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
pkg/workflow/cache.go
Outdated
|
|
||
| // Validate cache-memory file types step | ||
| var validateStep strings.Builder | ||
| fmt.Fprintf(&validateStep, " - name: Validate cache-memory file types (%s)\n", cache.ID) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot use helper to code generate actions/github-script code
pkg/workflow/cache.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot refactor this template template in a .md and render it
pkg/workflow/cache.go
Outdated
| } else { | ||
| fmt.Fprintf(builder, " - name: Validate cache-memory file types (%s)\n", cache.ID) | ||
| } | ||
| builder.WriteString(" if: always()\n") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot use helper to generate call to actions/github-script
🔍 PR Triage ResultsCategory: feature (security) | Risk: medium | Priority: 57/100 Scores Breakdown
📋 Recommended Action: batch_reviewMedium risk, medium priority (57/100), good quality. Not auto-mergeable due to pending CI and medium risk level. Should be reviewed but not urgent. Could be batched with other memory/security features if they exist. Batch Info: Eligible for batch-memory-security-001 (monitor for similar PRs) Triaged by PR Triage Agent on 2026-02-12T18:26:00Z (Run #21959060330)
|
|
@copilot keep working |
…cache prompts Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…ix template escaping, handle multi-config Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
🧪 Smoke Project is now testing project operations... |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
✅ Changeset Generator completed successfully! |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
Agent Container Tool Check ✅
Result: 12/12 tools available ✅ PASS
|
|
✅ Smoke Project completed successfully. All project operations validated. |
Smoke Test: Run 21968692105PRs Tested:
Results:
Status: PASS (8/9 tests passed) cc @pelikhan
|
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
PRs: Remove unused generateMaxWithRequiredFieldsConfig function / [WIP] Fix emission of --enable-chroot for awf call
|
Smoke Test Results ✅PR Titles:
Test Results:
Overall Status: PASS
|
|
Ok thanks for example Free website to gt
في الجمعة، ١٣ فبراير ٢٠٢٦، ٠٠:٤٨ github-actions[bot] <
***@***.***> كتب:
… *github-actions[bot]* left a comment (github/gh-aw#15195)
<#15195 (comment)>
📰 VERDICT: Smoke Copilot
<https://github.com/github/gh-aw/actions/runs/21968692105> has concluded.
All systems operational. This is a developing story. 🎤
—
Reply to this email directly, view it on GitHub
<#15195 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/B2DFN3QVCMPRHFXRK5SGLG34LUGNZAVCNFSM6AAAAACU5E6GLKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQOJUGAYTEMJSGQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Complete: Configurable File Type Restrictions with Code Review Fixes ✅
All Review Comments Addressed
Copilot PR Reviewer Feedback (bot comments 2801299441-2801299505):
$${to${in error messages@pelikhan Request:
6. ✅ Recompile: All 147 workflows recompiled successfully
Changes Summary
JavaScript Validation (validate_memory_files.cjs):
.map(ext => ext.trim().toLowerCase())[".MD", ".Json"]correctlyError Handling (push_repo_memory.cjs):
JSON.parse(ALLOWED_EXTENSIONS)in try-catchTemplate Fix (cache.go):
Found $${result...}→Found ${result...}$3Multi-Config Support:
Testing
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
Changeset
Changeset