Update merged notification comment in workflow#42925
Update merged notification comment in workflow#42925johnny1494 wants to merge 1 commit intogithub:repo-syncfrom
Conversation
Added a comment with a merge notification for pull requests.
|
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions:
You'll need to revert all of the files you changed that match that list using GitHub Desktop or The complete list of files we can't accept are:
We also can't accept contributions to files in the content directory with frontmatter |
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. This pull request contains code changes, so we will not generate a table of review links. 🤖 This comment is automatically generated. |
There was a problem hiding this comment.
Pull request overview
This pull request attempts to update the merged notification workflow that posts a comment when pull requests are merged. However, the change introduces a critical syntax error that will break the workflow.
Changes:
- Modified the
issue_numberline in the GitHub Actions workflow to add what appears to be an accidental number concatenation
| github.rest.issues.createComment({ | ||
| ...context.repo, | ||
| issue_number: context.payload.pull_request.number, | ||
| issue_number: context.payload.pull_request.number,2138420022 |
There was a problem hiding this comment.
Invalid syntax: The number 2138420022 has been concatenated directly to the end of the issue_number property without proper separation. This will cause a JavaScript syntax error when the workflow runs. The comma and property name should be on their own line, and this appears to be an accidental addition that should be removed entirely.
| issue_number: context.payload.pull_request.number,2138420022 | |
| issue_number: context.payload.pull_request.number, |
Added a comment with a merge notification for pull requests.
Why:
Closes:
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following: