test/robustness: rename makefile.mk to Makefile #19594
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This idea came from a robustness meeting where @serathius explained how the robustness tests
Makefilewas structured. Renaming the file toMakefileallows users to executemakecommands from thetests/robustnessdirectory. However, to also be able to import it from the top-levelMakefile, we need to ensure that we are not using relative directories. This is simple to achieve by introducing variables to the repository's top-level, and executing the top-levelmake/Makefilefrom the robustness by using make's--directoryargument.Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
/cc @serathius