Skip to content

Conversation

@ivanvc
Copy link
Member

@ivanvc ivanvc commented Mar 13, 2025

This idea came from a robustness meeting where @serathius explained how the robustness tests Makefile was structured. Renaming the file to Makefile allows users to execute make commands from the tests/robustness directory. However, to also be able to import it from the top-level Makefile, we need to ensure that we are not using relative directories. This is simple to achieve by introducing variables to the repository's top-level, and executing the top-level make/Makefile from the robustness by using make's --directory argument.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

/cc @serathius

@codecov
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.86%. Comparing base (82a3e6f) to head (be3eee2).
Report is 18 commits behind head on main.

Additional details and impacted files

see 19 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19594      +/-   ##
==========================================
+ Coverage   68.81%   68.86%   +0.05%     
==========================================
  Files         421      421              
  Lines       35897    35897              
==========================================
+ Hits        24703    24722      +19     
+ Misses       9768     9753      -15     
+ Partials     1426     1422       -4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82a3e6f...be3eee2. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ivanvc
Copy link
Member Author

ivanvc commented Mar 13, 2025

/retest

Allow to execute make targets from the tests/robustness directory.

Signed-off-by: Ivan Valdes <ivan@vald.es>
@ivanvc ivanvc force-pushed the rename-robustness-makefile branch from 9199ed5 to be3eee2 Compare March 14, 2025 16:44
@ivanvc ivanvc requested a review from serathius March 14, 2025 16:45
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius
Copy link
Member

This is really awesome!

@serathius serathius merged commit b988791 into etcd-io:main Mar 16, 2025
33 checks passed
@ivanvc ivanvc deleted the rename-robustness-makefile branch March 17, 2025 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants