SPMI: Run superpmi-diffs on windows-x64 #124343
Conversation
While osx-arm64 is the fastest Helix queues we have the AzDO pool is currently heavily overloaded and causes hour long waits before builds start or Helix jobs are even submitted. Switch to linux-x64 for diffs to avoid this.
github-actions
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
There was a problem hiding this comment.
Pull request overview
Updates the CoreCLR SuperPMI diffs Azure Pipelines configuration to run diffs on linux_x64 instead of osx_arm64, reducing queue/start delays caused by the overloaded macOS AzDO pool.
Changes:
- Switch SuperPMI diffs pipeline platform from
osx_arm64tolinux_x64for both the build and diffs jobs. - Remove the extra macOS-specific “Build SuperPMI (x64)” post-build step that was needed due to cross-arch tooling on macOS.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/coreclr/jit/importer.cpp | Minor reordering of CORINFO_RESOLVED_TOKEN field assignments in impResolveToken. |
| eng/pipelines/coreclr/superpmi-diffs.yml | Moves SuperPMI diffs execution/build from macOS arm64 to Linux x64 and removes macOS-only extra build step. |
| pResolvedToken->tokenScope = info.compScopeHnd; | ||
| pResolvedToken->tokenContext = impTokenLookupContextHandle; |
There was a problem hiding this comment.
In impResolveToken, the assignments to CORINFO_RESOLVED_TOKEN inputs are now out of order vs both the struct definition (tokenContext precedes tokenScope in corinfo.h) and other nearby initializations in this file. Keeping a consistent field-assignment order makes it easier to audit that all required inputs are set and avoids accidental omissions during future edits.
| pResolvedToken->tokenScope = info.compScopeHnd; | |
| pResolvedToken->tokenContext = impTokenLookupContextHandle; | |
| pResolvedToken->tokenContext = impTokenLookupContextHandle; | |
| pResolvedToken->tokenScope = info.compScopeHnd; |
| buildConfig: checked | ||
| platforms: | ||
| - osx_arm64 | ||
| - linux_x64 |
There was a problem hiding this comment.
| - linux_x64 |
jakobbotsch
changed the title
1 participant
While osx-arm64 is the fastest Helix queues we have the AzDO pool is currently heavily overloaded and causes hour long waits before builds start or Helix jobs are even submitted. Switch to windows-x64 for diffs to avoid this.