-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-49248: [Release] Include checksum in vote email #49249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amoeba
wants to merge
13
commits into
apache:main
Choose a base branch
from
amoeba:release/gh-49248--checksum-in-vote-thread
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
GH-49248: [Release] Include checksum in vote email #49249
amoeba
wants to merge
13
commits into
apache:main
from
amoeba:release/gh-49248--checksum-in-vote-thread
+24
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@raulcd this is ready for a review. I opted to put the checksum as a footnote since it's >80 chars and I didn't think it would look good if it was in the main text. Happy to do something else. |
kou
reviewed
Feb 12, 2026
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Resolves #49248
What changes are included in this PR?
Adds a step to the
SOURCE_VOTEstep in02-source.shto grab the checksum we just pushed to svn from dist.apache.org and include that checksum as a footnote in the vote thread email. I did it this way because the person running this script may run this script like,So the only way to get the checksum at this point is with another SVN command or by downloading the file from dist.apache.org.
Are these changes tested?
Yes, using currently active RC and with the above command.
Are there any user-facing changes?
No.