Story types: fix StoryFns used as React components #75472
+237
−215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 3.02 MB ℹ️ View Unchanged
|
aduth
reviewed
Feb 12, 2026
Comment on lines
+69
to
+77
| render: Template, | ||
| args: { | ||
| colors: [ | ||
| { name: 'Red', color: '#f00' }, | ||
| { name: 'White', color: '#fff' }, | ||
| { name: 'Blue', color: '#00f' }, | ||
| ], | ||
| value: '#00f', | ||
| }, |
Member
There was a problem hiding this comment.
Could we simplify these to properly extend the default story? (Same question applies to other stories in these files)
Suggested change
| render: Template, | |
| args: { | |
| colors: [ | |
| { name: 'Red', color: '#f00' }, | |
| { name: 'White', color: '#fff' }, | |
| { name: 'Blue', color: '#00f' }, | |
| ], | |
| value: '#00f', | |
| }, | |
| ...Default, | |
| args: { | |
| ...Default.args, | |
| value: '#00f', | |
| }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spinoff from the React 19 upgrade in #61521 that fixes some storybook types. The problem is that a function of type
StoryFncan no longer be used as a React component:StoryFnis somewhat compatible, it has apropsfirst argument and a secondcontextargument that wouldn't be used. But React 19 types are more strict than before and reject this.I refactored the three story files where this was a problem:
FontSizePickerWithStateare now regular React components, not stories.StoryFnfunctions usages were refactored toStoryObjobjects. Seems to be like a more elegant pattern which avoids creating mutliple copies of a story function with.bind({}).