Skip to content

Conversation

@aswamy
Copy link
Contributor

@aswamy aswamy commented Feb 11, 2026

WHY are these changes introduced?

All CLI commands that send metrics are erroring out with the following error

OTLPExporterError: Export failed with retryable status
    at _promiseQueue.pushPromise._transport.send.then.resultCallback.code (/Users/alokswamy/src/github.com/Shopify/cli/node_modules/.pnpm/@opentelemetry+otlp-exporter-base@0.57.0_@opentelemetry+api@1.9.0/node_modules/@opentelemetry/otlp-exporter-base/build/src/otlp-export-delegate.js:78:28)
    at process.processTicksAndRejections (node:internal/process/task_queues:103:5)

This would suppress the errors in console, but doesn't solve the fact that the commands are still trying to HIT the server and failing

WHAT is this pull request doing?

  • disabling metric logs in console

How to test your changes?

If OTEL server is still down, you should see this

image.png

  • run this branch and run SHOPIFY_CLI_ALWAYS_LOG_METRICS=1 npx shopify version at the root level of the project
    • you should not see any metrics errors

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

aswamy commented Feb 11, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2026

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.9% 14555/18448
🟡 Branches 73.23% 7223/9863
🟡 Functions 79.09% 3704/4683
🟡 Lines 79.25% 13762/17366

Test suite run success

3771 tests passing in 1453 suites.

Report generated by 🧪jest coverage report action from 19faac6

@aswamy aswamy marked this pull request as ready for review February 11, 2026 21:35
@aswamy aswamy requested review from a team as code owners February 11, 2026 21:35
@aswamy aswamy requested a review from EvilGenius13 February 11, 2026 21:40
@aswamy aswamy force-pushed the 02-11-suppress_otel_errors_in_console branch from 62088dc to 19faac6 Compare February 11, 2026 21:42
@EvilGenius13
Copy link
Contributor

I think App Inner Loop is building something that will encompass your change plus more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants