Merge pull request #21299 from henrybear327/robustness/clean_up_runWatchLoop_log

serathius · web-flow · commit 405a607c23cd · 2026-02-12T17:08:47.000+01:00
Robustness: reduce log noise in runWatchLoop
diff --git a/tests/robustness/traffic/traffic.go b/tests/robustness/traffic/traffic.go
@@ -401,10 +401,9 @@ func runWatchLoop(ctx context.Context, p RunWatchLoopParam, cfg watchLoopConfig)
 		if err != nil {
 			return
 		}
-		err = runWatch(ctx, p, cfg)
-		if err != nil {
-			p.Logger.Error("runWatchLoop: Get failed", zap.Error(err))
-		}
+		// Client.get may fail when the blackhole is injected.
+		// We suppress logging for these expected failures to avoid polluting the logs.
+		_ = runWatch(ctx, p, cfg)
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -401,10 +401,9 @@ func runWatchLoop(ctx context.Context, p RunWatchLoopParam, cfg watchLoopConfig)`
`401`	`401`	`if err != nil {`
`402`	`402`	`return`
`403`	`403`	`}`
`404`		`- err = runWatch(ctx, p, cfg)`
`405`		`- if err != nil {`
`406`		`- p.Logger.Error("runWatchLoop: Get failed", zap.Error(err))`
`407`		`- }`
	`404`	`+ // Client.get may fail when the blackhole is injected.`
	`405`	`+ // We suppress logging for these expected failures to avoid polluting the logs.`
	`406`	`+ _ = runWatch(ctx, p, cfg)`
`408`	`407`	`}`
`409`	`408`	`}`
`410`	`409`